Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: Rename osrd_containers by editoast_common #7066

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Mar 29, 2024

closes #7065
Part of #7067

@hamz2a hamz2a requested a review from a team as a code owner March 29, 2024 16:30
@hamz2a hamz2a force-pushed the hai/editoast-rename-osrd-containers-by-editoast-common branch from 033558e to f4d36aa Compare March 29, 2024 16:32
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.95%. Comparing base (a6faf4c) to head (f4d36aa).

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7066      +/-   ##
============================================
- Coverage     28.95%   28.95%   -0.01%     
  Complexity     2244     2244              
============================================
  Files          1070     1070              
  Lines        132543   132543              
  Branches       2713     2713              
============================================
- Hits          38379    38373       -6     
- Misses        92587    92593       +6     
  Partials       1577     1577              
Flag Coverage Δ
core 79.81% <ø> (ø)
editoast 74.82% <ø> (-0.03%) ⬇️
front 9.29% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamz2a hamz2a added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2024
@woshilapin woshilapin added this pull request to the merge queue Apr 2, 2024
Merged via the queue into dev with commit a1f4cbd Apr 2, 2024
22 checks passed
@woshilapin woshilapin deleted the hai/editoast-rename-osrd-containers-by-editoast-common branch April 2, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename osrd_containers by editoast_common
3 participants